fix(StructuredListInput): remove onChange deprecation warning #13368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move-structurelist-deprecation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tw15egan
approved these changes
Mar 17, 2023
|
@tay1orjones just need to update snapshots 👍🏻 |
aledavila
approved these changes
Mar 17, 2023
…move-structurelist-deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported on slack
I think what happened here was that
onChangewasn't being called in v10. It looks like as part of the large a11y refactor of the Structured List components, an early commit added the deprecation warning. Later on, theonChangewas updated to actually be used and the deprecation warning wasn't removed like it should've been.Changelog
Removed
onChangedeprecation warningTesting / Reviewing