Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add warning helper #8021

Merged
merged 2 commits into from
Mar 10, 2021
Merged

feat(react): add warning helper #8021

merged 2 commits into from
Mar 10, 2021

Conversation

andreancardona
Copy link
Contributor

Closes #8017

  • Added custom warning helper function

Changelog

Testing / Reviewing

  • Make sure all tests pass for warning helper

  • Make sure warning helper functions just as properly as our current warn function

@andreancardona andreancardona requested a review from a team as a code owner March 8, 2021 22:58
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! 🔥

@netlify
Copy link

netlify bot commented Mar 10, 2021

Deploy preview for carbon-elements ready!

Built with commit c5e949d

https://deploy-preview-8021--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 10, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit c5e949d

https://deploy-preview-8021--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit 9f1287c into carbon-design-system:main Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert warning usage to console.warn
3 participants