Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert warning usage to console.warn #8017

Closed
3 tasks done
joshblack opened this issue Mar 8, 2021 · 0 comments · Fixed by #8021 or #8114
Closed
3 tasks done

Convert warning usage to console.warn #8017

joshblack opened this issue Mar 8, 2021 · 0 comments · Fixed by #8021 or #8114
Assignees

Comments

@joshblack
Copy link
Contributor

joshblack commented Mar 8, 2021

We currently use the warning module to emit warnings to developers when a code path they have encountered is deprecated. However, the warning module uses console.error under the hood, instead of console.warn, which has caused some issues that both our team and those in the React ecosystem has faced in terms of confusion.

Instead, it would be great if we could transition to console.warn usage instead of console.error, most likely through our own implementation of warning that we could then use in the codebase.

  • Make our custom warning function
  • Update where our code uses warning to use our custom warning function
  • Remove the warning dependency from carbon-components-react
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants