-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CopyButton): ensure copy text is placed over icons #7611
Conversation
Deploy preview for carbon-elements ready! Built with commit 5c06c06 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 5c06c06 https://deploy-preview-7611--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Closes #7324
Closes #7605
Ensures Copy button feedback text is placed over other Copy button icons. Also fixes an issue with multiple CodeSnippets being placed on top of each other.
Changelog
New
z-index: 3
added to.#{$prefix}--copy-btn__feedback
Testing / Reviewing
Go to https://codesandbox.io/s/wonderful-cori-nnk8g?file=/index.js and find the
.bx--copy-btn .bx--copy-btn__feedback
in the inspector. Then addz-index: 3;
and ensure the feedback tex is placed over subsequentCopyButton
instances