-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CodeSnippet): add feedbackTimeout prop, z-index fix #8171
Conversation
Deploy preview for carbon-elements ready! Built with commit 6bb1e63 |
Deploy preview for carbon-components-react ready! Built with commit 6bb1e63 https://deploy-preview-8171--carbon-components-react.netlify.app |
Deploy preview for carbon-elements ready! Built with commit 68b2837 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 68b2837 https://deploy-preview-8171--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for adding that demo story for review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks awesome, thank you :)
DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. 1 out of 2 committers have signed the DCO. |
recheck |
Closes #8167
Closes #8168
This adds in the
feedbackTimeout
prop to all variants ofcodeSnippet
.Additionally, it sets the
z-index
value of the feedback tooltip to the same value as other tooltips.Changelog
New
feedbackTimeout
prop is now available to allCodeSnippet
variants. Knob added to storybook.Changed
z('floating')
for icon tooltips, making them consistent with other tooltips.Testing / Reviewing
Look at the demo story in
CodeSnippet
and ensure no tooltips are rendered behind a code snippet / copy button. Will remove story before merging 👍🏻