Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CodeSnippet): add feedbackTimeout prop, z-index fix #8171

Merged
merged 6 commits into from
Mar 30, 2021

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Mar 23, 2021

Closes #8167
Closes #8168

This adds in the feedbackTimeout prop to all variants of codeSnippet.

Additionally, it sets the z-index value of the feedback tooltip to the same value as other tooltips.

Changelog

New

  • feedbackTimeout prop is now available to all CodeSnippet variants. Knob added to storybook.

Changed

  • added z('floating') for icon tooltips, making them consistent with other tooltips.

Testing / Reviewing

Look at the demo story in CodeSnippet and ensure no tooltips are rendered behind a code snippet / copy button. Will remove story before merging 👍🏻

@tw15egan tw15egan requested a review from a team as a code owner March 23, 2021 19:47
@tw15egan tw15egan changed the title Snippet fixes feat(CodeSnippet): add feedbackTimeout prop, z-index fix Mar 23, 2021
@tw15egan tw15egan requested a review from a team as a code owner March 23, 2021 19:53
@netlify
Copy link

netlify bot commented Mar 23, 2021

Deploy preview for carbon-elements ready!

Built with commit 6bb1e63

https://deploy-preview-8171--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 23, 2021

Deploy preview for carbon-components-react ready!

Built with commit 6bb1e63

https://deploy-preview-8171--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Mar 23, 2021

Deploy preview for carbon-elements ready!

Built with commit 68b2837

https://deploy-preview-8171--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 23, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 68b2837

https://deploy-preview-8171--carbon-components-react.netlify.app

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for adding that demo story for review!

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome, thank you :)

@github-actions
Copy link
Contributor

DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


1 out of 2 committers have signed the DCO.
@tw15egan
@kodiakhq[bot]
You can retrigger this bot by commenting recheck in this Pull Request

@tw15egan
Copy link
Collaborator Author

recheck

@kodiakhq kodiakhq bot merged commit f020e54 into carbon-design-system:main Mar 30, 2021
@tw15egan tw15egan deleted the snippet-fixes branch March 3, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants