Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(project): move bundler to cli #7555

Merged

Conversation

joshblack
Copy link
Contributor

This PR introduces an internal refactor to merge @carbon/bundler and @carbon/cli. As a result, all commands in bundler are now in carbon-cli and @carbon/bundler has been removed from the project. This PR also removes commands from bundler that were no longer used in the project.

Changelog

New

Changed

  • Update all instances of bundler to be carbon-cli
  • Move bundler commands to packages/cli

Removed

  • packages/bundler has been removed

Testing / Reviewing

  • Verify the build passes as expected
  • Verify packages using carbon-cli bundle compile as expected

@joshblack joshblack requested a review from a team as a code owner January 13, 2021 23:36
@joshblack joshblack changed the title Refactor/move bundler to cli refactor(project): move bundler to cli Jan 13, 2021
@netlify
Copy link

netlify bot commented Jan 13, 2021

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: 1a86745

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fff83faa2f90700087d054f

😎 Browse the preview: https://deploy-preview-7555--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 14, 2021

✔️ Deploy preview for carbon-components-react ready!

🔨 Explore the source changes: 1a86745

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5fff83fa73bdc20007e5a837

😎 Browse the preview: https://deploy-preview-7555--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 14, 2021

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: f39c3dc

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/60020c1149dbf400077a6135

😎 Browse the preview: https://deploy-preview-7555--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 14, 2021

✔️ Deploy preview for carbon-components-react ready!

🔨 Explore the source changes: f39c3dc

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/60020c11cea4140008bc21ca

😎 Browse the preview: https://deploy-preview-7555--carbon-components-react.netlify.app

@joshblack
Copy link
Contributor Author

CI failure is a prettier change, made a PR for that over in: #7568 to try and keep things separate

@joshblack
Copy link
Contributor Author

FYI @emyarod @andreancardona that prettier PR got in so the lint check should be missing now!

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshblack looks good 🍔 !

@joshblack joshblack merged commit 6eb7928 into carbon-design-system:master Jan 16, 2021
@joshblack joshblack deleted the refactor/move-bundler-to-cli branch January 16, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants