Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elements): update colors, layout, and motion packages with experimental Sass Modules #7546

Merged
merged 11 commits into from
Jan 25, 2021
Merged

feat(elements): update colors, layout, and motion packages with experimental Sass Modules #7546

merged 11 commits into from
Jan 25, 2021

Conversation

joshblack
Copy link
Contributor

This is part of our exploration into Sass Modules, both to help with authoring Sass files but also to assist in compilation times.

This PR introduces the following changes:

  • Move the colors/scss/module.scss file to colors/index.scss. This allows us to reference the styles at @carbon/colors which is the current preference for Sass Modules going forward
  • Update @carbon/layout to include an entrypoint and temporary modules folder
  • Update @carbon/motion to include an entrypoint
  • Add initial v11 docs for @carbon/layout and @carbon/motion

Changelog

New

  • New Sass Module entrypoints for Colors, Layout, and Motion

Changed

  • Moved colors module entrypoint from scss/module.scss to index.scss

Removed

@joshblack joshblack requested a review from a team as a code owner January 12, 2021 22:50
@netlify
Copy link

netlify bot commented Jan 12, 2021

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: a0cfdff

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5ffe27ce34cc1800076fb554

😎 Browse the preview: https://deploy-preview-7546--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 12, 2021

❌ Deploy preview for carbon-components-react failed.

🔨 Explore the source changes: a0cfdff

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5ffe27cea3ae5700077af067

@netlify
Copy link

netlify bot commented Jan 12, 2021 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit b03b0b1

https://deploy-preview-7546--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 12, 2021 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit b03b0b1

https://deploy-preview-7546--carbon-elements.netlify.app

@joshblack
Copy link
Contributor Author

Let me know if you have any questions @aledavila @tw15egan !

Noticed the build failing, will try and update the bundler check since it doesn't understand Sass Modules at the moment 👀

@joshblack joshblack requested a review from dakahn January 13, 2021 20:39
@joshblack
Copy link
Contributor Author

Should be good after #7555 which uses sass under the hood now 👀

@joshblack
Copy link
Contributor Author

Let me know if you have any questions @dakahn @aledavila !

@joshblack joshblack changed the title Update colors, layout, and motion packages to Sass Modules feat(elements): update colors, layout, and motion packages with experimental Sass Modules Jan 20, 2021
tw15egan
tw15egan approved these changes Jan 21, 2021
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing any issues with a clean build, LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit adb7cd1 into carbon-design-system:master Jan 25, 2021
@emyarod emyarod mentioned this pull request Apr 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@aledavila aledavila aledavila approved these changes

@tw15egan tw15egan tw15egan approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshblack @tw15egan @aledavila @dakahn