Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabs): remove role knob #6981

Merged
merged 2 commits into from
Oct 6, 2020
Merged

fix(tabs): remove role knob #6981

merged 2 commits into from
Oct 6, 2020

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Oct 6, 2020

Removes the role knob, as this prop was removed in #6964 . This was causing the role to still appear in the storybook.

@tw15egan tw15egan requested a review from a team as a code owner October 6, 2020 17:58
@tw15egan tw15egan requested review from joshblack and dakahn October 6, 2020 17:58
@tw15egan tw15egan mentioned this pull request Oct 6, 2020
Merged
@netlify
Copy link

netlify bot commented Oct 6, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 7716d43

https://deploy-preview-6981--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 6, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 7716d43

https://deploy-preview-6981--carbon-components-react.netlify.app

carmacleod
carmacleod reviewed Oct 6, 2020
View reviewed changes
Copy link
Contributor

@carmacleod carmacleod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks, @tw15egan !

[Edit: I did select "Approve", but I guess GitHub ignored me. 😄 ]

emyarod
emyarod approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@kodiakhq kodiakhq bot merged commit 7e47efd into carbon-design-system:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmacleod carmacleod carmacleod left review comments

@emyarod emyarod emyarod approved these changes

@joshblack joshblack joshblack approved these changes

@dakahn dakahn Awaiting requested review from dakahn

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tw15egan @carmacleod @joshblack @emyarod