fix(Tabs): remove required role prop #6964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 498e794 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 498e794 https://deploy-preview-6964--carbon-components-react.netlify.app |
joshblack
approved these changes
Oct 5, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
|
I went to https://deploy-preview-6964--carbon-components-react.netlify.app/?path=/story/tabs--default
|
|
@carmacleod looks like it's a leftover knob in the storybook that was adding it. Pushed up a fix to remove that: #6981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6931
This PR removes the
roleprop requirement on the Tabs component to avoid a11y testing issues with navigation landmarksTesting / Reviewing
Confirm that
role="navigation"prop is no longer added by default to the Tabs component