chore(Toggle): changing fill color for disabled but checked small toggle #6955
Conversation
|
Deploy preview for carbon-elements ready! Built with commit dbec95a |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit dbec95a https://deploy-preview-6955--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 309b90c |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 309b90c https://deploy-preview-6955--carbon-components-react.netlify.app |
There was a problem hiding this comment.
@luizamendes this is a great first contribution! 🎊 Getting visual approval - but looks good on my end!
@aagonzales let me know if this looks good to you! See screenshots:
After change:
Before change:
There was a problem hiding this comment.
🎉 Congrats @luizamendes on your first contribution! Looks great 👍 ✅
Closes #6659
The objective is to change the style of the small toggle when it is checked but disabled.
This is my first time contributing ever.
Changelog
Changed
$disable-02to$disable-01, what makes the check icon appear.Testing / Reviewing
Start the storybook -> from
packages/reactfolderyarn storybookGo to ToggleSmall component -> checked version
Go to knobs and set it as disabled
You should see the check icon, stating that although the toggle is disabled it is checked.