Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle on-disabled just looks disabled #6659

Closed
designertyler opened this issue Aug 13, 2020 · 6 comments · Fixed by #6955
Closed

Toggle on-disabled just looks disabled #6659

designertyler opened this issue Aug 13, 2020 · 6 comments · Fixed by #6955
Assignees
Labels
hacktoberfest See https://hacktoberfest.com/ proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖

Comments

@designertyler
Copy link
Contributor

@Roninnanaki commented on Wed May 27 2020

Hi,

I am looking at creating an experience using toggles to determine if a service is going to be installed, active, off, or forced on. I continue to get feedback from my team and potential end-users that the toggles that are on and disabled just look like they are disabled.

Here is an example of the design that we are looking to implement. The last item for Auditing is on and disabled because the user cannot change this due to another setting or policy in the account.

example

I did take a look at the toggle page in carbon and didn't see any documentation for the on-disabled state. I found this state through the Sketch library.

sketch-library

Lastly, just to share an exploration here is some idea I put together as a solution based on the feedback/suggestions I heard from my design team.

potential-solution


@eraymond25 commented on Wed May 27 2020

+1 to this

here is another available option
Screen Shot 2020-05-27 at 12 37 40 PM

and heads up we're trying to release this in the next few months so would love to collab on a more clear disabled on state asap

@designertyler designertyler added proposal: open This request has gone through triaging. We're determining whether we take this on or not. role: ux 🍿 labels Aug 13, 2020
@emyarod emyarod added proposal: accepted This request has gone through triaging and we are accepting PR's against it. and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Sep 11, 2020
@emyarod
Copy link
Member

emyarod commented Sep 11, 2020

This proposal has been accepted, just need component spec updates from our designers before development begins

@aagonzales
Copy link
Member

Let's go with the below direction. Add checkmark to disabled:on using $disabled-01 color.

image.png

@tw15egan tw15egan added hacktoberfest See https://hacktoberfest.com/ and removed hacktoberfest See https://hacktoberfest.com/ labels Sep 29, 2020
@luizamendes
Copy link
Contributor

luizamendes commented Oct 1, 2020

Hello. I would like to take this issue, if that's okay. This will be my first time contributing, what should I do next? Thanks

@tw15egan
Copy link
Collaborator

tw15egan commented Oct 1, 2020

@luizamendes
Copy link
Contributor

@tw15egan I have forked the repo and followed the instructions. How can I have this issue assigned to me?

@tw15egan
Copy link
Collaborator

tw15egan commented Oct 1, 2020

Done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest See https://hacktoberfest.com/ proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants