Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook): Convert stories from storiesOf to CSF format #6663

Merged
merged 5 commits into from
Aug 14, 2020

Conversation

tw15egan
Copy link
Collaborator

Refs #6651

Begins work on updating Storybook to v6. Since storiesOf is deprecated in v6, we'll need to update them before we migrate.

Steps

  • Convert from storiesOf to CSF

Changelog

Changed

  • All stories have been converted from storiesOf format to CSF. Step 1 of the docs epic was to do this, so I just ran the codemod across the repo.
  • In v6 they will also deprecate the way we annotate stories, so I've also run that codemod to prepare for these changes (reference link)

Removed

Testing / Reviewing

Ensure each story still looks the same

@tw15egan tw15egan requested a review from a team as a code owner August 13, 2020 18:42
@tw15egan tw15egan requested review from joshblack and emyarod August 13, 2020 18:42
@netlify
Copy link

netlify bot commented Aug 13, 2020

Deploy preview for carbon-elements ready!

Built with commit 1e827d5

https://deploy-preview-6663--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 13, 2020

Deploy preview for carbon-components-react ready!

Built with commit 1e827d5

https://deploy-preview-6663--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

(although I think this will create merge conflicts for me with the mobile tabs PR 😭)

@kodiakhq kodiakhq bot merged commit 5af04eb into carbon-design-system:master Aug 14, 2020
@tw15egan tw15egan deleted the convert-to-csf branch April 28, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants