Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storybook): updates all stories to CSF format #6651

Closed

Conversation

tw15egan
Copy link
Collaborator

Begins work on updating Storybook to v6. Since storiesOf is deprecated in v6, we'll need to update them before we migrate.

Steps

  • Convert from storiesOf to CSF
  • Upgrade packages to v6

Changelog

New

  • @babel/plugin-proposal-logical-assignment-operators to fix an error on build

Changed

  • downshift updated from 5.2.1 to 5.2.7 to fix weird react-is error (cc @dakahn 😉 )
  • All stories have been converted from storiesOf format to CSF. Step 1 of the docs epic was to do this, so I just ran the codemod across the repo.

Removed

Testing / Reviewing

Ensure each story still looks the same

@netlify
Copy link

netlify bot commented Aug 11, 2020

Deploy preview for carbon-elements ready!

Built with commit 01d730c

https://deploy-preview-6651--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 11, 2020

Deploy preview for carbon-components-react ready!

Built with commit 01d730c

https://deploy-preview-6651--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Aug 11, 2020

Deploy preview for carbon-elements ready!

Built with commit da2f7ad

https://deploy-preview-6651--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 11, 2020

Deploy preview for carbon-components-react failed.

Built with commit da2f7ad

https://app.netlify.com/sites/carbon-components-react/deploys/5f356318244ad60008bbc7dc

@tw15egan
Copy link
Collaborator Author

Going to break this into two PR's (one to update to CSF, another to upgrade) to reduce the size

@tw15egan tw15egan closed this Aug 13, 2020
@tw15egan tw15egan deleted the convert-and-update branch April 28, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant