Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(data-table): update datatable docs #6430

Merged
merged 8 commits into from
Jul 14, 2020

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Jul 9, 2020

Closes #6413

Our Filtering / Batch Actions examples showed old icon usage. Currently, to add an icon into TableToolbarAction, you can just pass it in as a child.

Changelog

New

  • .alexrc file to ignore words like hook coming across the profanity filter

Changed

  • Updated Data Table examples to show an icon being passed down as a child of TableToolbarAction

Removed

  • Words due to Alex error

Testing / Reviewing

Nothing is broken

@tw15egan tw15egan requested a review from a team as a code owner July 9, 2020 18:13
@ghost ghost requested review from andreancardona and joshblack July 9, 2020 18:13
@netlify
Copy link

netlify bot commented Jul 9, 2020

Deploy preview for carbon-elements ready!

Built with commit 7cabdfa

https://deploy-preview-6430--carbon-elements.netlify.app

@tw15egan tw15egan force-pushed the data-table-docs-update branch from eda1f53 to e53aadc Compare July 9, 2020 18:33
@netlify
Copy link

netlify bot commented Jul 9, 2020

Deploy preview for carbon-components-react ready!

Built with commit 632cbb4

https://deploy-preview-6430--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jul 9, 2020

Deploy preview for carbon-components-react ready!

Built with commit f046cfa

https://deploy-preview-6430--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jul 9, 2020

Deploy preview for carbon-components-react ready!

Built with commit 39c8bfe

https://deploy-preview-6430--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jul 9, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 7cabdfa

https://deploy-preview-6430--carbon-components-react.netlify.app

@andreancardona andreancardona self-assigned this Jul 14, 2020
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tw15egan looks good to me! 🎉

@kodiakhq kodiakhq bot merged commit 4cfcec0 into carbon-design-system:master Jul 14, 2020
@tw15egan tw15egan deleted the data-table-docs-update branch April 28, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTable - icon is not displayed in TableToolbarAction
3 participants