Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable - icon is not displayed in TableToolbarAction #6413

Closed
1 of 2 tasks
zbeedatm opened this issue Jul 8, 2020 · 3 comments · Fixed by #6430
Closed
1 of 2 tasks

DataTable - icon is not displayed in TableToolbarAction #6413

zbeedatm opened this issue Jul 8, 2020 · 3 comments · Fixed by #6430

Comments

@zbeedatm
Copy link

zbeedatm commented Jul 8, 2020

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Summary

Trying to show an icon near to the itemText of TableToolbarAction but it's not working!

                                            <TableToolbarMenu>
                                                <TableToolbarAction
                                                    // icon={TrashCan20}
                                                    // showIcon={true}
                                                    // icon={iconSettings}
                                                    // iconDescription="Show Records"
                                                    itemText="Show Records"
                                                    // onClick={action('TableToolbarAction - Settings')}
                                                />

Is there a sandbox that i can take a look?

Relevant information

@tw15egan
Copy link
Collaborator

tw15egan commented Jul 8, 2020

Can you try just passing in an icon as a child of TableToolbarAction?

<TableToolbarAction>
   <Delete /> Action 1
</TableToolbarAction>

@zbeedatm
Copy link
Author

zbeedatm commented Jul 9, 2020

That's work for sure. But I tried following your readme in git!
https://github.com/carbon-design-system/carbon/blob/master/packages/react/src/components/DataTable/README.md#filtering

Thanks anyway

@tw15egan
Copy link
Collaborator

tw15egan commented Jul 9, 2020

Oof, good catch! I'll update the documentation now to reflect this. Thanks for bringing it to our attention 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants