fix(dropdowns): pass user ID's to Downshift #6326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 768d8d4 |
|
Deploy preview for carbon-components-react ready! Built with commit e933632 https://deploy-preview-6326--carbon-components-react.netlify.app |
|
Deploy preview for carbon-components-react ready! Built with commit 768d8d4 https://deploy-preview-6326--carbon-components-react.netlify.app |
tw15egan
requested changes
Jun 23, 2020
joshblack
reviewed
Jun 23, 2020
joshblack
reviewed
Jun 23, 2020
|
I think snapshots just need to be updated so they don’t have [Object object] |
joshblack
reviewed
Jun 24, 2020
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
|
Doing some quick digging (this is definitely grounds for some clean-up in the future) The version we're trying to get to matches:
|
emyarod
reviewed
Jun 24, 2020
|
@emyarod for dropdown it should show up on that node, if I understand correctly |
|
@emyarod @joshblack yeah, I believe the node should be where it ends up yeah |
|
Looking at the preview, seems like we get: Dropdown id on bx--dropdown bx--listbox Combobox id on input MultiSelect id on bx--multi-select bx--listbox |
emyarod
approved these changes
Jun 24, 2020
joshblack
approved these changes
Jun 24, 2020
gracelo
added a commit
to gracelo/carbon
that referenced
this pull request
Jun 30, 2020
* origin/master: (77 commits) feat(pictograms): add systems devops category and pictograms (carbon-design-system#6332) fix(button): prevent tooltip from showing on incorrect hover (carbon-design-system#6349) feat(pictograms): add coronavirus pictogram in Life Science category (carbon-design-system#6351) chore(npmignore): update npmignore file (carbon-design-system#6350) chore(project): sync generated files fix(pagination): set correct width on ghost buttons (carbon-design-system#6344) docs(text-area): rename story file to use camel case in component name (carbon-design-system#6334) chore(release): v10.15.0-rc.0 (carbon-design-system#6343) feat(pictograms): New add device pictogram (carbon-design-system#6333) fix(Dropdown): add downshiftProps handling (carbon-design-system#6341) feat(pictograms): add supply chain category with new pictograms (carbon-design-system#6305) feat(pictograms): add gift pictogram in retail (carbon-design-system#6336) feat(pictograms): add blender pictogram in lifestyle category (carbon-design-system#6318) fix(dropdowns): pass user ID's to Downshift (carbon-design-system#6326) fix(carbon): revert pr 6185 (carbon-design-system#6331) feat(react): remove unsafe lifecycle methods from DataTable and DatePicker (carbon-design-system#6307) docs(handbook): add icon docs to developer-handbook (carbon-design-system#6300) feat(pictograms): add planning analytics pictogram to cloud category (carbon-design-system#6320) chore(project): sync generated files fix(loading): use `$overlay-01` token for overlay (carbon-design-system#6323) ... # Conflicts: # packages/components/src/components/tabs/_tabs.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now without my goofy busted commit history ❤️
Closes #6304
In our updates we broke functionality for user supplied IDs getting passed down to Downshift. With this new implementation if the user provides a value for the
idprop Downshift will create anidprop using that supplied id for label, menu etc appending the name of the element as intended (id="address"would result inid="address-label",id="address-menu"etc on the child components)Changelog
idprop to wrapper componentidprop toselectPropsobjectidprop touseSelectand remove unused label IDsTesting / Reviewing
Go in the changed file and change the value for the
idprop to something distinct. Then open dev tools on the Storybook for that element and search for that new value which should be seen on label, field, and toggle buttons for each component.