-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(handbook): add icon docs to developer-handbook #6300
Conversation
Deploy preview for carbon-elements ready! Built with commit e52e36e |
Deploy preview for carbon-components-react ready! Built with commit e52e36e https://deploy-preview-6300--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we need to prettier
again on this file to pass CI
* origin/master: (77 commits) feat(pictograms): add systems devops category and pictograms (carbon-design-system#6332) fix(button): prevent tooltip from showing on incorrect hover (carbon-design-system#6349) feat(pictograms): add coronavirus pictogram in Life Science category (carbon-design-system#6351) chore(npmignore): update npmignore file (carbon-design-system#6350) chore(project): sync generated files fix(pagination): set correct width on ghost buttons (carbon-design-system#6344) docs(text-area): rename story file to use camel case in component name (carbon-design-system#6334) chore(release): v10.15.0-rc.0 (carbon-design-system#6343) feat(pictograms): New add device pictogram (carbon-design-system#6333) fix(Dropdown): add downshiftProps handling (carbon-design-system#6341) feat(pictograms): add supply chain category with new pictograms (carbon-design-system#6305) feat(pictograms): add gift pictogram in retail (carbon-design-system#6336) feat(pictograms): add blender pictogram in lifestyle category (carbon-design-system#6318) fix(dropdowns): pass user ID's to Downshift (carbon-design-system#6326) fix(carbon): revert pr 6185 (carbon-design-system#6331) feat(react): remove unsafe lifecycle methods from DataTable and DatePicker (carbon-design-system#6307) docs(handbook): add icon docs to developer-handbook (carbon-design-system#6300) feat(pictograms): add planning analytics pictogram to cloud category (carbon-design-system#6320) chore(project): sync generated files fix(loading): use `$overlay-01` token for overlay (carbon-design-system#6323) ... # Conflicts: # packages/components/src/components/tabs/_tabs.scss
Adds some documentation for how to review icon and pictogram pull requests
Changelog
New
Changed
Removed