Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(handbook): add icon docs to developer-handbook #6300

Merged
merged 11 commits into from
Jun 23, 2020
Merged

Conversation

joshblack
Copy link
Contributor

Adds some documentation for how to review icon and pictogram pull requests

Changelog

New

Changed

  • Add in documentation for how developers can review icon and pictogram pull requests

Removed

@joshblack joshblack requested a review from a team as a code owner June 16, 2020 23:13
@ghost ghost requested review from dakahn and emyarod June 16, 2020 23:13
@netlify
Copy link

netlify bot commented Jun 16, 2020

Deploy preview for carbon-elements ready!

Built with commit e52e36e

https://deploy-preview-6300--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 16, 2020

Deploy preview for carbon-components-react ready!

Built with commit e52e36e

https://deploy-preview-6300--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we need to prettier again on this file to pass CI

docs/developer-handbook.md Outdated Show resolved Hide resolved
@joshblack joshblack merged commit 8318e72 into master Jun 23, 2020
@joshblack joshblack deleted the joshblack-patch-1 branch June 23, 2020 20:37
gracelo added a commit to gracelo/carbon that referenced this pull request Jun 30, 2020
* origin/master: (77 commits)
  feat(pictograms): add systems devops category and pictograms (carbon-design-system#6332)
  fix(button): prevent tooltip from showing on incorrect hover (carbon-design-system#6349)
  feat(pictograms): add coronavirus pictogram in Life Science category (carbon-design-system#6351)
  chore(npmignore): update npmignore file (carbon-design-system#6350)
  chore(project): sync generated files
  fix(pagination): set correct width on ghost buttons (carbon-design-system#6344)
  docs(text-area): rename story file to use camel case in component name (carbon-design-system#6334)
  chore(release): v10.15.0-rc.0 (carbon-design-system#6343)
  feat(pictograms): New add device pictogram (carbon-design-system#6333)
  fix(Dropdown): add downshiftProps handling (carbon-design-system#6341)
  feat(pictograms): add supply chain category with new pictograms (carbon-design-system#6305)
  feat(pictograms): add gift pictogram in retail (carbon-design-system#6336)
  feat(pictograms): add blender pictogram in lifestyle category (carbon-design-system#6318)
  fix(dropdowns): pass user ID's to Downshift (carbon-design-system#6326)
  fix(carbon): revert pr 6185 (carbon-design-system#6331)
  feat(react): remove unsafe lifecycle methods from DataTable and DatePicker (carbon-design-system#6307)
  docs(handbook): add icon docs to developer-handbook (carbon-design-system#6300)
  feat(pictograms): add planning analytics pictogram to cloud category (carbon-design-system#6320)
  chore(project): sync generated files
  fix(loading): use `$overlay-01` token for overlay (carbon-design-system#6323)
  ...

# Conflicts:
#	packages/components/src/components/tabs/_tabs.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants