Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): import layout helpers #5786

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Apr 2, 2020

Closes #5785

This PR adds imports for the layout and typography globals in the global and component level tooltip styles

Testing / Reviewing

Confirm that layout and typography helpers are (z(), rem(), etc.) defined before being called

@emyarod emyarod requested a review from a team as a code owner April 2, 2020 14:45
@ghost ghost requested review from asudoh and joshblack April 2, 2020 14:45
@netlify
Copy link

netlify bot commented Apr 2, 2020

Deploy preview for carbon-elements ready!

Built with commit 3034cc8

https://deploy-preview-5786--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Apr 2, 2020

Deploy preview for carbon-components-react ready!

Built with commit 3034cc8

https://deploy-preview-5786--carbon-components-react.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @emyarod!

@asudoh
Copy link
Contributor

asudoh commented Apr 2, 2020

@emyarod thinks this is ready to merge - Thanks @emyarod!

@asudoh asudoh merged commit 4599048 into carbon-design-system:master Apr 3, 2020
@emyarod emyarod deleted the 5785-tooltip-z-index-helper-import branch June 10, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tooltip.scss uses, but does not import, function from layout.scss
4 participants