Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooltip.scss uses, but does not import, function from layout.scss #5785

Closed
2 tasks done
starpit opened this issue Apr 2, 2020 · 0 comments · Fixed by #5786
Closed
2 tasks done

tooltip.scss uses, but does not import, function from layout.scss #5785

starpit opened this issue Apr 2, 2020 · 0 comments · Fixed by #5786

Comments

@starpit
Copy link

starpit commented Apr 2, 2020

What package(s) are you using?

carbon-components 10.10.1

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

tooltip.scss uses the z() function that is defined in layout.scss, but it does not import that file. As a consequence, direct import of tooltip.scss into webpack builds does not render the tooltips with the expected z-index. Thus, tooltips can render below other elements of the UI.

Is this issue related to a specific component?

Tooltip and TooltipIcon

What did you expect to happen? What happened instead? What would you like to
see changed?

Hopefully this can be addressed by adding

@import '../../globals/scss/layout';

to _tooltip.scss. I observe that other components (modal, breadcrumb, switcher, etc.) all do so. _tooltip.scss is notable in its exception.

What browser are you working in?

Electron and various browsers. The problem seems independent of that.

What version of the Carbon Design System are you using?

10.10.1

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

https://github.com/IBM/kui

Additional information

  • Screenshots or code

Screen Shot 2020-04-02 at 9 37 19 AM

  • Notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants