feat(token): add new selected-light-ui token #5718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 2f87025 |
|
Deploy preview for carbon-components-react ready! Built with commit 2f87025 https://deploy-preview-5718--carbon-components-react.netlify.com |
laurenmrice
approved these changes
Mar 26, 2020
abbeyhrt
approved these changes
Mar 26, 2020
joshblack
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5715
Adds in a new
selected-light-uitoken. When there was a selected state in a row in the dark themes, the selected-ui color was the same as the field-0. This will allow us to fix that.Follow up PR will fix the problems listed in
MultiSelectChangelog
New
selected-light-uicolor tokenTesting / Reviewing
Make sure nothing is broken