Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new selected-ui-light color token #5715

Closed
tw15egan opened this issue Mar 26, 2020 · 0 comments · Fixed by #5718
Closed

Add new selected-ui-light color token #5715

tw15egan opened this issue Mar 26, 2020 · 0 comments · Fixed by #5718
Assignees
@tw15egan
Labels
role: dev 🤖 type: enhancement 💡

Comments

@tw15egan
Copy link
Collaborator

tw15egan commented Mar 26, 2020 •
edited
Loading

When there is selected state in a row in the dark themes, the selected-ui color is the same as the field-02 🤦🏼‍♀️, which then makes it looks wonky.
Screen Shot 2020-03-25 at 5 03 57 PM

Talked with Anna about it. We think we should just also make another token called selected-ui-light to be applied to selected states.

White G10 G90 G100
G20 #e0e0e0 G20 #e0e0e0 G60 #6f6f6f G70 #525252

I think I can approve this pr since its accomplishing what we wanted. but could tackle the above separately.

Originally posted by @laurenmrice in #5707 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw15egan tw15egan

Labels
role: dev 🤖 type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(token): add new selected-light-ui token tw15egan/carbon
2 participants
@tw15egan @laurenmrice