Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list-box): update background, border colors #5707

Merged
merged 3 commits into from
Mar 26, 2020

Conversation

tw15egan
Copy link
Collaborator

Closes #5705

Updates a few colors and uses the new decorative-01 token so horizontal rules (border-top) correctly show in dark themes on components that have a light prop

Changelog

Changed

  • Listbox components (MultiSelect, ComboBox) use field-02 as the menu background when light prop is applied
  • OverflowMenu uses field-02 as the menu background when light prop is applied
  • Any horizontal rule (border-top) is now using decorative-01 when light prop is applied

Testing / Reviewing

View these components in all 4 themes, and check that the rules show up when the light prop is applied

@tw15egan tw15egan requested a review from a team as a code owner March 25, 2020 20:40
@ghost ghost requested review from aledavila and emyarod March 25, 2020 20:40
@tw15egan tw15egan requested a review from laurenmrice March 25, 2020 20:40
@netlify
Copy link

netlify bot commented Mar 25, 2020

Deploy preview for carbon-elements ready!

Built with commit 04f4f31

https://deploy-preview-5707--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Mar 25, 2020

Deploy preview for carbon-components-react ready!

Built with commit 04f4f31

https://deploy-preview-5707--carbon-components-react.netlify.com

@laurenmrice
Copy link
Member

laurenmrice commented Mar 25, 2020

So the rules are looking correct with the new token in all themes. yay!

This was my bad for not finding this earlier because I only speced out the light themes, but when there is selected state in a row in the dark themes, the selected-ui color is the same as the field-02 🤦🏼‍♀️, which then makes it looks wonky.
Screen Shot 2020-03-25 at 5 03 57 PM


Talked with Anna about it. We think we should just also make another token called selected-ui-light to be applied to selected states.

White G10 G90 G100
G20 #e0e0e0 G20 #e0e0e0 G60 #6f6f6f G70 #525252

I think I can approve this pr since its accomplishing what we wanted. but could tackle the above separately.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@tw15egan tw15egan merged commit c76742b into carbon-design-system:master Mar 26, 2020
@tw15egan
Copy link
Collaborator Author

Dependent on #5688

@tw15egan tw15egan deleted the light-token-updates branch April 28, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[light prop] apply new token to components that have rules
5 participants