Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): update reset to use relative unit #5541

Merged
merged 3 commits into from
Mar 5, 2020
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/type/scss/_reset.scss
Original file line number Diff line number Diff line change
@@ -10,18 +10,18 @@
@import 'styles';

/// Include a type reset for a given body and mono font family
/// @param {Number} $base-font-size [$carbon--base-font-size] - The base font size for your document
/// @param {String} $body-font-family [carbon--font-family('sans')] - The font family used on the `<body>` element
/// @param {String} $mono-font-family [carbon--font-family('mono')] - The font family used on elements that require mono fonts, like the `<code>` element
/// @access public
/// @group @carbon/type
@mixin carbon--type-reset(
$base-font-size: $carbon--base-font-size,
// TODO: remove in next major release. This has been replaced with 100%
$base-font-size: $carbon--base-font-size,
$body-font-family: carbon--font-family('sans'),
$mono-font-family: carbon--font-family('mono')
) {
html {
font-size: $base-font-size;
font-size: 100%;
}

body {