fix(type): update reset to use relative unit #5541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
cc @dakahn I believe this was an issue we inadvertently had with any kind of text resize scenarios. I believe this is how we fix it (along with using relative units for type) but just wanted to give you a heads up in case this isn't the right solution. |
|
Deploy preview for carbon-components-react ready! Built with commit f030337 https://deploy-preview-5541--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit f030337 |
asudoh
approved these changes
Mar 5, 2020
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
Mar 10, 2020
* fix(type): update reset to use relative unit * chore(format): run prettier Co-authored-by: TJ Egan <[email protected]>
This was referenced Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have used a fixed value for the font-size in
htmlwhich incidentally causes text preferences to not be honored when set by the browser. This change updates the type reset to use a relative unit,100%, which should mean that our components respond appropriately when the user has browser preferences for text size.Changelog
New
Changed
htmlnow has a base font-size of100%Removed
Testing / Reviewing