fix: update TextInput and Select default size values #5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
This was referenced Feb 27, 2020
|
Deploy preview for carbon-elements ready! Built with commit 15294d6 |
|
Deploy preview for carbon-components-react ready! Built with commit 82d8647 https://deploy-preview-5478--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 82d8647 |
dakahn
approved these changes
Feb 28, 2020
joshblack
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5472 (comment)
Changes in #5472 & #5473 allowed an empty
sizeprop value in theTextInputandSelectcomponents.However, based on the conversation in #5472 (comment), it would be better to set
size="lg"by default in theTextInputandSelect, and then update their storybook demos to reflect this new default.Changelog
Changed
TextInput, setsizeprop to"lg"by default & update storybook demo'Select, setsizeprop to"lg"by default & update storybook demo