fix(select): allow empty string for size prop #5473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
jendowns
changed the title
|
Deploy preview for carbon-elements ready! Built with commit 0532d4f |
|
Deploy preview for carbon-components-react ready! Built with commit 0532d4f https://deploy-preview-5473--carbon-components-react.netlify.com |
asudoh
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
joshblack
approved these changes
Feb 27, 2020
|
@asudoh should we just remove the defaultProp with the empty string potentially? Was thinking about this over in the text input PR just now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5471
Currently
sizeis an empty string but default, but that is not allowed in the propTypes declaration. The generates errors where everSelectis used (including in storybook built off the latest).Changelog
Changed
sizepropTesting / Reviewing
See that there are no propTypes errors in the console when you view the storybook deploy, compared to the
masterbranch (or canary) storybook environment.