-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(link): remove visited styles by default #5239
Conversation
Deploy preview for the-carbon-components ready! Built with commit ee8ed54 https://deploy-preview-5239--the-carbon-components.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 91aed79 |
Deploy preview for carbon-components-react ready! Built with commit 91aed79 https://deploy-preview-5239--carbon-components-react.netlify.com |
Quick question, do we know when links should have the visited style versus not? Or is it up to a product team versus a system decision |
I believe we as a system want visited styles disabled but with the added functionality for a team to have visited links if they are required to have them. |
Most of the time in product links don't have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 assuming making visited state optional is the design intent. Thanks @tw15egan!
Do we know why the visited link color change was added? It was added pretty recently, v10.7 or 10.6 I think and it never seemed like anybody on our side wanted it |
I believe that was a v10 design language addition to add the purple visited link option. |
We added it for the website I think and somehow it became default in the component/ |
Isn't it overwritten in the website? |
Would love to see it go away in product for sure. The dot com team may have some research to back up keeping it in their world but not sure if they do. My hunch is it can be removed in dot com experiences as well. |
Closes #3581
Removes
:visited
styles by default. If the link has abx--link--visited
class, it will receive visited styles once a link has been visited.Not sure if
bx--link--visited
is the greatest name, since it will have that class before it is actually visited, so open to suggestions.Changelog
New
bx--link--visited
, which will add:visited
styles once a link has been clickedvisited
prop that will add the class that will allow visited styles when using ReactLink
Removed
:visited
styles by default.Testing / Reviewing
Click the first link, and see that it does not change to visited styles.
Click the second link, and see that it does receive visited styles.