Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(link): don't use visited color by default #16015

Merged

Conversation

janhassel
Copy link
Member

Ref #15790

Visited links should not render with the $link-visited-text-color token by default but only if opted in via the visited prop on the component (#5239). The v1.53.0 release included a regression.

Changelog

Changed

  • Use normal, non-visited, link color on :visited selector
    • Keep visited color on .cds--link--visited:visited selector

Testing / Reviewing

Storybook

@janhassel janhassel requested a review from a team as a code owner March 20, 2024 13:06
Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 864e1fe
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65fadf75fcea6900088179a7
😎 Deploy Preview https://deploy-preview-16015--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph added this pull request to the merge queue Mar 20, 2024
Merged via the queue into carbon-design-system:main with commit 4de1fc6 Mar 20, 2024
20 checks passed
@janhassel janhassel deleted the visited-link-color branch March 20, 2024 15:16
preetibansalui pushed a commit to tay1orjones/carbon that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants