feat(data-table): add data-table paths and aliases #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit cc72e35 https://deploy-preview-2292--the-carbon-components.netlify.com |
|
Deploy preview for the-carbon-components ready! Built with commit f65a6fe https://deploy-preview-2292--the-carbon-components.netlify.com |
asudoh
reviewed
Apr 11, 2019
There was a problem hiding this comment.
Thanks @joshblack for doing this! LGTM basically, one thing I found in the Netlify link is that some Fractal configurations need some updates, likely:
- For old directory - Add Fractal configuration just with
hidden: true, like one for floating menu - For new directory - Update the component name (removing
v2)
asudoh
approved these changes
Apr 11, 2019
vpicone
approved these changes
Apr 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2295
Add
data-tablefolder and appropriate aliases for JS and SCSS files. This diff does not include the deprecation warning fordata-table-v2, we should discuss that strategy and implement in another PR most likely 👍Changelog
New
data-table-v2now lives underdata-tableChanged
data-table-v2now points todata-tabledata-tableDataTableRemoved