Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use plex as per family #17683

Merged
merged 11 commits into from
Nov 15, 2024
Merged

Conversation

riddhybansal
Copy link
Contributor

Closes #11661

Updates @carbon/styles to have flexibility of using both individual @ibm/plex-${font-style} packages and @ibm/plex by using a variable use-per-family-plex which is false by default.

Changelog

New

  • 8 new packages for each of the @ibm/plex families
Screenshot 2024-07-25 at 9 17 15 AM
  • font-feature-settings: 'liga' 1; added to _reset.scss to ensure ligatures render even with letter-spacing set
  • $package-name field added to font src resolver

Changed

  • Updated the url field in font src resolver to use new package name format when use-per-family-plex is true

Removed

Testing / Reviewing

Ensure the fonts are loaded correctly, either using the Akamai CDN or not. Ensure the fi ligature renders properly.

@riddhybansal riddhybansal requested a review from a team as a code owner October 8, 2024 18:54
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9c0ed39
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67366a2f6a8a33000813e22f
😎 Deploy Preview https://deploy-preview-17683--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 9c0ed39
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67366a2f12dfc800077c90b7
😎 Deploy Preview https://deploy-preview-17683--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (0cfda56) to head (9c0ed39).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17683      +/-   ##
==========================================
+ Coverage   81.81%   82.19%   +0.37%     
==========================================
  Files         404      404              
  Lines       14067    14151      +84     
  Branches     4413     4418       +5     
==========================================
+ Hits        11509    11631     +122     
+ Misses       2395     2359      -36     
+ Partials      163      161       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good!🥳

It would be nice if the existing documentation could be updated to reflect this change and surface the new config option. I'm specifically thinking about the .md we have in the repo that covers how to self-host plex and write your own font resolver, etc.

Probably need some new docs as well covering stuff like:

  • What happens if both $use-akamai-cdn and $use-per-family-plex are set to true?
  • How would someone migrate from $use-akamai-cdn?
  • How would someone migrate from basic/existing $font-path usage?
  • What will be the default in the next major

packages/styles/scss/_config.scss Outdated Show resolved Hide resolved
@tay1orjones
Copy link
Member

If you'd like to put the documentation work in a different issue/PR, I'd be fine approving and merging this 👍

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 9c0ed39
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67366a2f8159000008cd3933
😎 Deploy Preview https://deploy-preview-17683--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things I saw - I'll work on a small refactor and push the changes to this PR

docs/guides/ibm-plex.md Outdated Show resolved Hide resolved
docs/guides/ibm-plex.md Outdated Show resolved Hide resolved
docs/guides/ibm-plex.md Outdated Show resolved Hide resolved
docs/guides/ibm-plex.md Outdated Show resolved Hide resolved
@tay1orjones tay1orjones self-assigned this Nov 6, 2024
@tay1orjones
Copy link
Member

I pushed an update here, let me know what you think!

@riddhybansal
Copy link
Contributor Author

I pushed an update here, let me know what you think!

Oh I see what you have done here !! These details will be helpful.

@tay1orjones tay1orjones added this pull request to the merge queue Nov 15, 2024
Merged via the queue into carbon-design-system:main with commit bda9d1e Nov 15, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Plex is not up to date, package is too large
3 participants