Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plex is not up to date, package is too large #11661

Closed
3 of 4 tasks
tay1orjones opened this issue Jun 22, 2022 · 8 comments · Fixed by #17683
Closed
3 of 4 tasks

Plex is not up to date, package is too large #11661

tay1orjones opened this issue Jun 22, 2022 · 8 comments · Fixed by #17683
Assignees
Milestone

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Jun 22, 2022

We're working to update how Plex is published - IBM/plex#452. It's likely Plex will start to publish individual packages per-family.

Currently we're blocked by this. The compressed package binary is too large, IBM/plex#453. Once this has been addressed, we need to update packages:

Checklist

  • Update Plex package(s) and versions
  • Determine how we would need to revise the sass font resolver, and then update it
  • Ensure no regressions
  • Put together an e2e/percy snapshot for the Plex families Carbon includes (nice to have)

Workaround

To use the most up to date Plex assets with Carbon, you can configure the sass to use the Akamai server. It can be configured via the $use-akamai-cdn scss config variable.

@mjabbink
Copy link

@tay1orjones @alisonjoseph Making the note here that the “fi” ligature should be the default setting. Whatever Carbon for IBM.com is doing and what Carbon did with v10 is the correct expectation.

@sstrubberg
Copy link
Member

sstrubberg commented Apr 26, 2023

@tay1orjones can you remind me where we're at with this? Is this the one we're moving to Brand?

@tay1orjones tay1orjones modified the milestones: 2023 Q2, 2023 Q3 Jun 15, 2023
@tay1orjones
Copy link
Member Author

@sstrubberg This issue is for the work we need to do in this carbon repo, no matter who updates the Plex repo. We can't do this work until the Plex repo is updated and publishes an npm package for each Plex font family.

@tay1orjones tay1orjones added this to the 2024 Q3 milestone Jul 1, 2024
@tay1orjones tay1orjones moved this from ⏱ Backlog to 🏗 In Progress in Design System Jul 17, 2024
@tay1orjones
Copy link
Member Author

Closed via #17025

Thanks again @tw15egan! 🎉

@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Design System Aug 14, 2024
@tay1orjones
Copy link
Member Author

The original fix was reverted in #17211, we need to revisit this and determine a way to introduce this change without breaking projects that are already configuring $font-path

@tay1orjones tay1orjones reopened this Aug 20, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to ⏱ Backlog in Design System Aug 20, 2024
@s100
Copy link
Contributor

s100 commented Sep 12, 2024

I'm interested in seeing this fixed. Currently our application has several direct and indirect dependencies which pull in @ibm/[email protected], meanwhile we also use @carbon/styles which pulls in @ibm/[email protected]. The IBM Plex font package is large in itself, but having two of them is quite inconvenient.

@github-project-automation github-project-automation bot moved this to Triage in Roadmap Sep 16, 2024
@sstrubberg sstrubberg modified the milestones: 2024 Q3, 2024 Q4 Sep 16, 2024
@sstrubberg sstrubberg moved this from Triage to Next ➡ in Roadmap Sep 16, 2024
@sstrubberg sstrubberg moved this from Next ➡ to Now 💫 in Roadmap Sep 16, 2024
@sstrubberg sstrubberg moved this from Now 💫 to Next ➡ in Roadmap Sep 16, 2024
@tay1orjones tay1orjones moved this from Next ➡ to Now 💫 in Roadmap Sep 25, 2024
@tay1orjones tay1orjones modified the milestones: 2024 Q4, 2024 Q3 Sep 25, 2024
@tay1orjones
Copy link
Member Author

The approach we're circling around for the second rev of this is to introduce a new boolean config variable (false by default) that allows users to opt into the new pathing. The paths can still use the existing $font-path variable, just modify the / to be -{familyName}/. We considered deprecating $font-path, but that's not necessary.

This approach will result in essentially the same PR that @tw15egan already did, but with

  • the addition of the new variable
  • making sure we don't uninstall @ibm/plex as it'll still be needed for the "legacy" pathing

Some new docs around this change would be good to have as well. I think there's a few places $font-path is used/documented.

@sstrubberg sstrubberg modified the milestones: 2024 Q3, 2024 Q4 Oct 9, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Design System Nov 15, 2024
@github-project-automation github-project-automation bot moved this from Now 💫 to Completed 🚢 in Roadmap Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants