fix(overflowmenu): improve autoAlign
fallback placements
#17248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a slack conversation, this improves the fallback placements for OverflowMenu's
autoAlign
. Here's an example of the problem:2024-08-22.at.12.46.01-MAIN-Google.Chrome.mp4
With this PR it avoids vertically flipping unless it absolutely has to:
2024-08-22.at.12.48.36-MAIN-Google.Chrome.mp4
Changelog
New
fallbackPlacements
based on the value ofmenuAlignment
Changed
Removed
fallbackAxisSideDirection
because it's ignored whenfallbackPlacements
is usedTesting / Reviewing