Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating UI: Review, validate, and test alignment - defaults, optional values, fallbackPlacement, fallbackAxisSideDirection #17250

Open
12 tasks
Tracked by #14139
tay1orjones opened this issue Aug 22, 2024 · 0 comments
Labels
Milestone

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Aug 22, 2024

Through #17248 we uncovered a logical error with how autoAlign positioned the OverflowMenu when the initial placement didn't fit. Similar issues exist in the other components with alignment options and that support autoAlign.

We need to go through and meticulously look at every component and variant (like isTabTip) to:

  1. Determine if it's only allowing the approved alignments per component/variant
  2. Ensure that it chooses the proper fallback alignment(s) when the default(s) don't fit
  3. Standardize the auto align stories for each of these components to something that is polished, the same between all of them, and will work with VRT
  4. Add these stories to VRT

There are very specific docs on the types of alignment options available to every popover-based element and variant. The same exists for Menus.

Important

If there is any confusion on how these should behave, the fallback order preference, etc., consult a design lead and document the decision in the issue.

Tasks

Preview Give feedback
@tay1orjones tay1orjones added the planning: umbrella Umbrella issues, surfaced in Projects views label Aug 22, 2024
@tay1orjones tay1orjones changed the title Floating UI: Review and validate alignment defaults, options, fallbackPlacement, fallbackAxisSideDirection against design specifications Floating UI: Review, validate, and test alignment - defaults, optional values, fallbackPlacement, fallbackAxisSideDirection Aug 22, 2024
@tay1orjones tay1orjones added type: docs 📖 package: @carbon/react @carbon/react type: infrastructure 🤖 Issues relating to devops, tech debt, etc. labels Aug 22, 2024
@sstrubberg sstrubberg moved this to 🪆 Needs Refined in Design System Sep 4, 2024
@sstrubberg sstrubberg moved this from 🪆 Needs Refined to ⏱ Backlog in Design System Sep 4, 2024
@sstrubberg sstrubberg added this to the 2024 Q3 milestone Sep 4, 2024
@sstrubberg sstrubberg added role: dev 🤖 and removed planning: umbrella Umbrella issues, surfaced in Projects views labels Sep 4, 2024
@tay1orjones tay1orjones modified the milestones: 2024 Q3, 2024 Q4 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

2 participants