-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating UI: Allow floating-ui-based positioning without autoAlign
collision detection
#17018
Comments
FWIW, the reason I asked for this is that you currently can't specify an alignment and concurrently use
It will ignore the
That's a great question... I don't have a direct answer but ISTM that we should change the defaults to be:
I realize that's the opposite of what you said ("opt in"), but it's food for thought. |
@wkeese how you describe is how it should be working today.
That shouldn't be the case, all implementations use the
If you're seeing the opposite, I'm happy to look into it if you could put together a stackblitz repro or steps to repro in storybook. We're planning to ensure this type of thing is working correctly across all the components: |
@annawen1 @ariellalgilmore @preetibansalui summarizing our meeting yesterday, the tentative plan we came up with is to add a new feature flag allowing consumers to toggle on "dynamic" floating-ui
This will also provide us a path to make the "dynamic" styling and/or collision detection on-by-default in the future. It would likely be considered a breaking change though, so we'd have to reserve it for our next major. |
Right now to take advantage of the
position: fixed
strategy used byfloating-ui
, users must useautoAlign
, which includes collision detection.In theory these two could be separated, allowing consumers to take advantage of the benefits of fixed positioning, most notably avoiding clipping of ancestor elements, without having to use
autoAlign
collision detection.Open questions
Examples
The text was updated successfully, but these errors were encountered: