-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(combobox): memoize floating ui ref to prevent max call depth #16866
Merged
tay1orjones
merged 2 commits into
carbon-design-system:main
from
tay1orjones:16857-combobox-allowCustomInput-bug
Jun 26, 2024
Merged
fix(combobox): memoize floating ui ref to prevent max call depth #16866
tay1orjones
merged 2 commits into
carbon-design-system:main
from
tay1orjones:16857-combobox-allowCustomInput-bug
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2nikhiltom
approved these changes
Jun 26, 2024
guidari
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Merged
via the queue into
carbon-design-system:main
with commit Jun 26, 2024
305c274
22 checks passed
tay1orjones
added a commit
to tay1orjones/carbon
that referenced
this pull request
Jun 26, 2024
…bon-design-system#16866) Co-authored-by: Nikhil Tomar <[email protected]>
Closed
This was referenced Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16857
This PR does to primary things:
getMenuProps
to avoid an infinite loopautoAlign={true}
The first fixes the problem outlined in the original issue, the second is an indirect improvement. If the refs had initially been guarded, this bug would've been isolated to users using
autoAlign
. Because the refs were not guarded, the bug was present for everyone regardless of ifautoAlign
was being used.From what I can tell, there is not a reliable way to unit test this as the keyboard entry rate isn't configurable.
Changelog
Changed
getMenuProps
inuseMemo
Testing / Reviewing
allowCustomInput
combobox storywith experimental autoalign
combobox storyautoAlign
works as expected on combobox by resizing the browser window, playing with scroll, and opening/closing the listbox