Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating UI: Memoize problematic downshift prop getters to prevent infinite loops #17007

Closed
4 tasks done
Tracked by #14139
tay1orjones opened this issue Jul 19, 2024 · 0 comments
Closed
4 tasks done
Tracked by #14139

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Jul 19, 2024

There's a longstanding interop issue between floating ui and downshift where in certain cases when setting a ref an infinite loop can happen causing the component to crash.

The solution is to memoize the result of downshift's getMenuProps(). We've already had to do this for two components, we should expand this solution out to all the rest of the downshift components.

Tasks

  1. status: ready to merge 🎉
  2. status: ready to merge 🎉
  3. component: multiselect
    riddhybansal
  4. component: filterable-multiselect
    riddhybansal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant