Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint16 #16617

Closed
wants to merge 17 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .stylelintignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
**/packages/colors/**/*.scss
**/packages/elements/scss/**/*.scss
**/packages/themes/**/*.scss
**/packages/**/generated/**/*.scss

# packages/components
packages/components/demo/**
Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
2 changes: 1 addition & 1 deletion config/eslint-config-carbon/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@
},
"devDependencies": {
"babel-preset-carbon": "workspace:^",
"prettier": "^2.8.8"
"prettier": "^3.2.5"
}
}
2 changes: 1 addition & 1 deletion config/prettier-config-carbon/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
"provenance": true
},
"peerDependencies": {
"prettier": "2.x"
"prettier": "3.2.5"
}
}
21 changes: 10 additions & 11 deletions config/stylelint-config-carbon/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,16 @@

'use strict';

module.exports = {
export default {
extends: [
require.resolve('stylelint-config-standard'),
require.resolve('stylelint-no-unsupported-browser-features'),
require.resolve('stylelint-config-idiomatic-order'),
require.resolve('stylelint-config-standard-scss'),
require.resolve('./rules/possible-errors'),
require.resolve('./rules/limit-language-features'),
require.resolve('./rules/stylistic-issues'),
require.resolve('./plugins/a11y'),
require.resolve('./plugins/prettier'),
require.resolve('./plugins/scss'),
'stylelint-config-standard',
'stylelint-no-unsupported-browser-features',
'stylelint-config-idiomatic-order',
'stylelint-config-standard-scss',
'./rules/possible-errors',
'./rules/limit-language-features',
'./rules/stylistic-issues',
'./plugins/a11y',
'./plugins/scss',
],
};
18 changes: 9 additions & 9 deletions config/stylelint-config-carbon/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "1.19.0",
"license": "Apache-2.0",
"main": "index.js",
"type": "module",
"repository": {
"type": "git",
"url": "https://github.com/carbon-design-system/carbon.git",
Expand All @@ -24,22 +25,21 @@
"provenance": true
},
"peerDependencies": {
"stylelint": "^15.0.0"
"stylelint": "^16.0.0"
},
"dependencies": {
"stylelint-a11y": "^1.2.3",
"@double-great/stylelint-a11y": "^3.0.2",
"stylelint-config-idiomatic-order": "^10.0.0",
"stylelint-config-prettier": "^9.0.3",
"stylelint-config-standard": "^34.0.0",
"stylelint-config-standard-scss": "^11.0.0",
"stylelint-no-unsupported-browser-features": "^7.0.0",
"stylelint-config-standard": "^36.0.0",
"stylelint-config-standard-scss": "^13.1.0",
"stylelint-no-unsupported-browser-features": "^8.0.1",
"stylelint-order": "^6.0.0",
"stylelint-prettier": "^2.0.0",
"stylelint-scss": "^4.1.0",
"stylelint-scss": "^6.2.1",
"stylelint-use-logical": "^2.1.0"
},
"devDependencies": {
"prettier": "^2.8.8",
"stylelint": "^15.0.0"
"prettier": "^3.2.5",
"stylelint": "^16.0.0"
}
}
4 changes: 2 additions & 2 deletions config/stylelint-config-carbon/plugins/a11y.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

'use strict';

module.exports = {
plugins: ['stylelint-a11y'],
export default {
plugins: ['@double-great/stylelint-a11y'],
rules: {
'a11y/media-prefers-reduced-motion': true,
},
Expand Down
16 changes: 0 additions & 16 deletions config/stylelint-config-carbon/plugins/prettier.js

This file was deleted.

2 changes: 1 addition & 1 deletion config/stylelint-config-carbon/plugins/scss.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

const OFF = null;

module.exports = {
export default {
plugins: ['stylelint-scss', 'stylelint-use-logical'],
rules: {
// @-else
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

const OFF = null;

module.exports = {
export default {
rules: {
// Color
// Require (where possible) or disallow named colors.
Expand Down Expand Up @@ -110,8 +110,6 @@ module.exports = {
'selector-max-combinators': OFF,
// Limit the number of compound selectors in a selector.
'selector-max-compound-selectors': OFF,
// Limit the number of adjacent empty lines within selectors.
'selector-max-empty-lines': OFF,
// Limit the number of id selectors in a selector.
'selector-max-id': OFF,
// Limit the specificity of selectors.
Expand Down
3 changes: 1 addition & 2 deletions config/stylelint-config-carbon/rules/possible-errors.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

const OFF = null;

module.exports = {
export default {
rules: {
// Color
'color-no-invalid-hex': true,
Expand Down Expand Up @@ -65,7 +65,6 @@ module.exports = {
'no-duplicate-at-import-rules': true,
'no-duplicate-selectors': true,
'no-empty-source': true,
'no-extra-semicolons': true,
// Doesn't trigger when using a preprocessor that allows double slash
// comments
'no-invalid-double-slash-comments': true,
Expand Down
Loading
Loading