Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint16 #16617

Closed
wants to merge 17 commits into from
Closed

Stylelint16 #16617

wants to merge 17 commits into from

Conversation

lee-chase
Copy link
Member

Closes #16604

Updates to stylelint 16

Testing / Reviewing

Running the script lint:styles

NOTE: Still work to do, many stylistic rules deprecated in 15 gone in 16.

See - https://stylelint.io/migration-guide/to-15#deprecated-stylistic-rules

@lee-chase
Copy link
Member Author

  • stylelint-config-prettier is obsolete in stylelint 16.

prettier/stylelint-config-prettier#139

@lee-chase
Copy link
Member Author

Added 'declaration-block-no-redundant-longhand-properties': OFF, to stylistic rules.
Removed some unnecessary disables.
Added '/packages//generated/**/*.scss' to stylelint ignore which might be better dealt with by preventing this empty file generation.

image

@lee-chase lee-chase marked this pull request as ready for review May 30, 2024 10:15
@lee-chase lee-chase requested a review from a team as a code owner May 30, 2024 10:15
@lee-chase lee-chase requested review from alisonjoseph and guidari May 30, 2024 10:15
Copy link

netlify bot commented May 31, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 29691a3
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66d828006fc7110008a62997
😎 Deploy Preview https://deploy-preview-16617--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 31, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 29691a3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66d82800a93393000888a738
😎 Deploy Preview https://deploy-preview-16617--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones
Copy link
Member

tay1orjones commented Jun 5, 2024

IIRC When Stylelint 15 came out @tw15egan had a hard time detangling it from prettier v3, which caused #14744 to not make it through.

If we need to update prettier alongside this we could try to do so, but it'll reach into more packages within ./config

@lee-chase
Copy link
Member Author

lee-chase commented Jun 13, 2024

IIRC When Stylelint 15 came out @tw15egan had a hard time detangling it from prettier v3, which caused #14744 to not make it through.

If we need to update prettier alongside this we could try to do so, but it'll reach into more packages within ./config

Prettier V4 is still in alpha, with no releases in the last six months. Not sure we should tie it to Storybook 16. An update to Prettier V3 should be simple enough.

@tay1orjones
Copy link
Member

Closing in favor of #17770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Update stylelint-config-carbon for Stylelint 16
5 participants