15757 create a controlled accordion stories #15827
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Kritvi-bhatia17
added
status: one more review 👀
and removed
status: ready for review 👀
labels
There was a problem hiding this comment.
As discussed in the call, I have some concerns regarding the solutioning:
- Placing two primary CTAs/buttons next to each other is not recommended.
- This could potentially create confusion for users, as the CTAs seem like a part of the component/design rather than just props.
Possible solutions:
- We could create a tab called 'Examples' under 'Accordion' where we can place the 'Controlled' tab.
- We could explore alternative placements or methods for presenting the CTAs.
For further steps, I can connect with the team to determine the best course of action.
There was a problem hiding this comment.
This LGTM from a dev perspective.
@Kritvi-bhatia17 could we just add two small ghost buttons for the demo? The topic of adding Example or Demo stories has come up several times in dev meetings, but I think its a bigger discussion vs. creating it for a one-off component.
There was a problem hiding this comment.
Hey @alisonjoseph , just wanted to let you know that @alina-jacob brought this up during our design critique call today. We decided to stick with the current design for now since it's already in progress. But we can definitely tackle this later on down the road!
Looks good @preetibansalui 🔥
0474bce
Closes #15757
Added controlled story in Accordion
New
Testing / Reviewing