Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an controlled Accordion stories #15757

Closed
2 tasks done
guidari opened this issue Feb 14, 2024 · 1 comment · Fixed by #15827
Closed
2 tasks done

Create an controlled Accordion stories #15757

guidari opened this issue Feb 14, 2024 · 1 comment · Fixed by #15827
Assignees
@riddhybansal @2nikhiltom @preetibansalui
Labels
component: accordion role: dev 🤖

Comments

@guidari
Copy link
Contributor

guidari commented Feb 14, 2024 •
edited by 2nikhiltom
Loading

A lot of users have been asking questions regarding the Accordion usage when it comes to the controlled state from AccordionItem.
Here it is an example of what you are gonna build: https://stackblitz.com/edit/github-trp7pj-sgzpfm?file=src%2FApp.jsx

  • Create a new story called Controlled
  • Add testing using Playwright:
    • Add ACViolations checker
    • Add keyboard navigation testing
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Feb 14, 2024
@carbon-design-system carbon-design-system deleted a comment from github-actions bot Feb 14, 2024
@guidari guidari moved this from Triage to Now in Roadmap Feb 14, 2024
@guidari guidari removed this from Roadmap Feb 14, 2024
@guidari guidari moved this to ⏱ Backlog in Design System Feb 14, 2024
@riddhybansal riddhybansal moved this from ⏱ Backlog to 🏗 In Progress in Design System Feb 16, 2024
@preetibansalui preetibansalui mentioned this issue Feb 27, 2024
Merged
@preetibansalui preetibansalui moved this from 🏗 In Progress to 🚦 In Review in Design System Feb 27, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 mentioned this issue Mar 5, 2024
Open
@Kritvi-bhatia17
Copy link
Contributor

Solution: PR #15827

Screenshot 2024-03-06 at 12 24 26 AM

@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riddhybansal riddhybansal

@2nikhiltom 2nikhiltom

@preetibansalui preetibansalui

Labels
component: accordion role: dev 🤖
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

15757 create a controlled accordion stories preetibansalui/carbon
5 participants
@riddhybansal @guidari @2nikhiltom @preetibansalui @Kritvi-bhatia17