fix(Notification): allow undefined props in TypeScript #15068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Oct 30, 2023
alisonjoseph
approved these changes
Oct 31, 2023
alisonjoseph
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
tay1orjones
removed this pull request from the merge queue due to the queue being cleared
Merged
via the queue into
carbon-design-system:main
with commit Oct 31, 2023
b4a5d05
14 checks passed
tay1orjones
added a commit
to tay1orjones/carbon
that referenced
this pull request
Nov 1, 2023
…-system#15068) Co-authored-by: Taylor Jones <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TypeScript type definitions for the Notification component family: makes
kind,onCloseButtonClickandroleprops optional, to match component behavior (defaults set) and PropTypes definition.Changelog
Changed
kind,onCloseButtonClickandroleprops when used in TypeScript projectTesting / Reviewing
In a TypeScript project, using Notification components properly resorts to using default values for
kind,onCloseButtonClickandroleprops.