Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: typescript error for InlineNotification #15079

Closed
2 tasks done
petermoogk opened this issue Nov 1, 2023 · 2 comments
Closed
2 tasks done

[Bug]: typescript error for InlineNotification #15079

petermoogk opened this issue Nov 1, 2023 · 2 comments
Assignees

Comments

@petermoogk
Copy link

Package

@carbon/react

Browser

Firefox

Package version

v1.41.1

React version

v17.0.2

Description

In the recent 1.41.1 version of @Carbon/react the InlineNotification component is now giving an error that it wasn't giving before. Typescript is now requiring a value for the role attribute and the onCloseButtonClick attribute. The documentation for InlineNotification indicates that these attributes have default values. https://react.carbondesignsystem.com/?path=/story/components-notifications-toast--default
For role the docs indicate that the default is "status". For onCloseButtonClick the default is suppose to be a noop. Thanks!

Reproduction/example

NA

Steps to reproduce

Create in InlineNotification component without role or onCloseButtonClick . Typescript will give a compilation error, preventing the application from starting.

The work around is to add these attributes to the component.

Suggested Severity

Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.

Application/PAL

React app

Code of Conduct

@tay1orjones
Copy link
Member

Thanks for reporting this @petermoogk, we'd welcome a PR to update the types if you're able.

@tw15egan
Copy link
Collaborator

Fixed via #15068

@github-project-automation github-project-automation bot moved this from ⏱ Backlog to ✅ Done in Design System Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants