Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NumberInput.js): replaced pipe character with || operator #12662

Conversation

jt-helsinki
Copy link
Contributor

@jt-helsinki jt-helsinki commented Nov 16, 2022

  • fixed syntax error.

Closes #12661

ReadOnly prop not being recognised correctly. Changed pipe (|) character to OR (||). Now works.

Changelog

New

  • N/A

Changed

  • NumberInput.js

Removed

  • N/A

Testing / Reviewing

View the code. This is a syntax error fix.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

DCO Assistant Lite bot All contributors have signed the DCO.

@netlify
Copy link

netlify bot commented Nov 16, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 19a0d82
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6374e7f5c92896000a445b1d
😎 Deploy Preview https://deploy-preview-12662--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 16, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 19a0d82
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6374e7f5b7f0e30008d0d88a
😎 Deploy Preview https://deploy-preview-12662--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jt-helsinki
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that!

@kodiakhq kodiakhq bot merged commit 66561ff into carbon-design-system:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: NumberInput React component not recognising readOnly correctly
3 participants