Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: NumberInput React component not recognising readOnly correctly #12661

Closed
2 tasks done
jt-helsinki opened this issue Nov 16, 2022 · 0 comments · Fixed by #12662
Closed
2 tasks done

[Bug]: NumberInput React component not recognising readOnly correctly #12661

jt-helsinki opened this issue Nov 16, 2022 · 0 comments · Fixed by #12662

Comments

@jt-helsinki
Copy link
Contributor

Package

@carbon/react

Browser

Chrome

Package version

1.14.0

React version

18

Description

The NumberInput component does not disable the up/down buttons when the component is marked as "readOnly". The problem appears to be that the || operand is not specified correctly on lines 198 and 223. Fix is simple replace the pipe (|) character with an OR operator (||).

This appears to be a simple syntax error.

Suggested Severity

Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.

Reproduction/example

Not needed

Steps to reproduce

Look at the code. It's a syntax error.

Code of Conduct

@jt-helsinki jt-helsinki changed the title [Bug]: Number Input not recognising readOnly correctly [Bug]: NumberInput React component not recognising readOnly correctly Nov 16, 2022
@kodiakhq kodiakhq bot closed this as completed in #12662 Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant