Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storybook): storybook modal footer button settings #12593

Merged
merged 3 commits into from
Nov 15, 2022
Merged

fix(storybook): storybook modal footer button settings #12593

merged 3 commits into from
Nov 15, 2022

Conversation

Djunnni
Copy link
Contributor

@Djunnni Djunnni commented Nov 10, 2022 •
edited by tay1orjones
Loading

Closes #12443

Changelog

Changed

  • readd numberOfButtons in modal playbook

스크린샷 2022-11-10 오후 7 37 12

  • change disabled: true about secondaryButtonText and onSecondarySubmit
    • because it's not working when readd numberOfButtons. if it can be, maybe change Modal code

Testing / Reviewing

only change packages/react/src/components/Modal/Modal.stories.js

@Djunnni Djunnni requested a review from a team as a code owner November 10, 2022 10:42
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@Djunnni
Copy link
Contributor Author

Djunnni commented Nov 10, 2022

I have read the DCO document and I hereby sign the DCO.

@netlify
Copy link

netlify bot commented Nov 10, 2022 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dc19f9e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6373414781e8a00009c0338a
😎 Deploy Preview https://deploy-preview-12593--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 10, 2022 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit dc19f9e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6373414788d9500008ff249f
😎 Deploy Preview https://deploy-preview-12593--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tay1orjones
tay1orjones approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Control in storybook looks good, thanks!

@kodiakhq kodiakhq bot merged commit 09e54fe into carbon-design-system:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledavila aledavila aledavila approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore Modal three button example
3 participants
@Djunnni @tay1orjones @aledavila