Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Modal three button example #12443

Closed
2 tasks
tay1orjones opened this issue Oct 31, 2022 · 5 comments · Fixed by #12593
Closed
2 tasks

Restore Modal three button example #12443

tay1orjones opened this issue Oct 31, 2022 · 5 comments · Fixed by #12593
Assignees
@Djunnni
Labels
good first issue 👋 Used by GitHub to elevate contribution opportunities role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Oct 31, 2022 •
edited
Loading

The three button example was removed from the modal in this PR #12013, we need to add it back in.

#12443 (comment)
@tay1orjones tay1orjones added severity: 3 https://ibm.biz/carbon-severity type: bug 🐛 role: dev 🤖 good first issue 👋 Used by GitHub to elevate contribution opportunities labels Oct 31, 2022
@Djunnni
Copy link
Contributor

Djunnni commented Nov 1, 2022

i want try this

@tw15egan
Copy link
Collaborator

tw15egan commented Nov 1, 2022

@Djunnni all yours!

@Djunnni
Copy link
Contributor

Djunnni commented Nov 5, 2022

i have a question about that.

modal three button means footer three button?

@tay1orjones
Copy link
Member Author

@Djunnni yes, you can still see it on the storybook for the previous major version by setting the controls/knobs

https://v7-react.carbondesignsystem.com

@Djunnni
Copy link
Contributor

Djunnni commented Nov 9, 2022

thanks :)

@Djunnni Djunnni mentioned this issue Nov 10, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #12593 Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Djunnni Djunnni

Labels
good first issue 👋 Used by GitHub to elevate contribution opportunities role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(storybook): storybook modal footer button settings Djunnni/carbon
3 participants
@tay1orjones @tw15egan @Djunnni