Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FilterableMultiselect): remove extra invalid border #12078

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Sep 9, 2022

Closes #11875

Removes double border when an item is selected in FilterableMultiselect

Changelog

Changed

  • added a :not to the form invalid styles logic

Testing / Reviewing

Go to FilterableMultiselect playground, set invalid, and then select an item. There should only be one invalid border.

@netlify
Copy link

netlify bot commented Sep 9, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit f6a9858
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/631b1ae91b870b000923eb46
😎 Deploy Preview https://deploy-preview-12078--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 9, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f6a9858
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/631b1ae9c54e0d000961cb03
😎 Deploy Preview https://deploy-preview-12078--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit 171a610 into carbon-design-system:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect red border on invalid inline filterable multiselect
3 participants