Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect red border on invalid inline filterable multiselect #11875

Closed
2 tasks done
ccwilson-us-ibm-com opened this issue Jul 28, 2022 · 2 comments · Fixed by #12078
Closed
2 tasks done

[Bug]: Incorrect red border on invalid inline filterable multiselect #11875

ccwilson-us-ibm-com opened this issue Jul 28, 2022 · 2 comments · Fixed by #12078
Assignees
Labels
good first issue 👋 Used by GitHub to elevate contribution opportunities severity: 2 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@ccwilson-us-ibm-com
Copy link

Package

@carbon/react, @carbon/styles

Browser

Chrome, Firefox

Package version

v1.8.0

React version

^17.0.0

Description

When setting the invalid state on an inline filterable multiselect component, two overlapping red borders are rendered. This occurs when at least one option is selected and the dropdown listbox is closed. I believe there should only be a single border.

Reproduction/example

https://stackblitz.com/edit/github-yxfgii?file=src/App.jsx

Steps to reproduce

Here's how the component is configure to display this issue:

<FilterableMultiSelect
          ariaLabel="Filterable MultiSelect"
          id="filterable-multiselect-example"
          items={items}
          label="Filterable multiselect options"
          titleText="Filterable multiselect title"
          type="inline"
          invalid="true"
        />

And then select at least on option in the component.

Code of Conduct

@ccwilson-us-ibm-com
Copy link
Author

Screen shot for reference:
Screen Shot 2022-07-28 at 10 57 53 AM

@tay1orjones
Copy link
Member

Thanks for the report @ccwilson-us-ibm-com, you're right the intent is for only a single red outline to be present. We'll work on a fix.

@tay1orjones tay1orjones assigned tay1orjones and unassigned abbeyhrt Aug 15, 2022
@jnm2377 jnm2377 added the good first issue 👋 Used by GitHub to elevate contribution opportunities label Aug 15, 2022
@tay1orjones tay1orjones assigned tw15egan and unassigned tay1orjones Aug 29, 2022
@kodiakhq kodiakhq bot closed this as completed in #12078 Sep 12, 2022
Repository owner moved this from ⏱ Backlog to ✅ Done in Design System Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 👋 Used by GitHub to elevate contribution opportunities severity: 2 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants