fix(type): fix heading type styles based on guidance and design kit #12037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
abbeyhrt
requested review from
a team and
thyhmdo
and removed request for
a team
…into type-style-fixes
abbeyhrt
approved these changes
Sep 6, 2022
jnm2377
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed a few discrepancies between some implementd heading type styles and their counterparts on the website and figma kit. I updated the scss and js definitions.
Changelog
Changed
heading-05: updated font weightfixed in fix(type): update v11 token values #11920heading-05: updated font weightfixed in fix(type): update v11 token values #11920Testing / Reviewing
Verify the heading styles in the compiled
@carbon/typepackage match the specification.