Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type): update v11 token values #11920

Merged
merged 10 commits into from
Aug 31, 2022
Merged

fix(type): update v11 token values #11920

merged 10 commits into from
Aug 31, 2022

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Aug 5, 2022 •
edited
Loading

Closes #11865

Changelog

New

  • add token detail collapsible section to type elements example preview

Changed

Testing / Reviewing

  • View the elements type preview, ensure the values have been updated to the new values

@netlify
Copy link

netlify bot commented Aug 5, 2022 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit b1e28b2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/630f8bac7ae5d00008735133
😎 Deploy Preview https://deploy-preview-11920--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 5, 2022 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b1e28b2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/630f8bac9ffa800009ac0047
😎 Deploy Preview https://deploy-preview-11920--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tay1orjones tay1orjones marked this pull request as ready for review August 23, 2022 19:00
@tay1orjones tay1orjones requested a review from a team as a code owner August 23, 2022 19:00
tw15egan
tw15egan approved these changes Aug 24, 2022
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

aagonzales
aagonzales reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the weight is wrong in two spots, but I might be reading something wrong too.

packages/type/scss/_styles.scss Outdated Show resolved Hide resolved
packages/type/src/styles.js Outdated Show resolved Hide resolved
@tay1orjones tay1orjones changed the title fix(type): update token values fix(type): update v11 token values Aug 29, 2022
@kodiakhq kodiakhq bot merged commit 396300d into carbon-design-system:main Aug 31, 2022
@janhassel janhassel mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@aagonzales aagonzales aagonzales approved these changes

@jnm2377 jnm2377 Awaiting requested review from jnm2377

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update v11 type tokens in monorepo
3 participants
@tay1orjones @aagonzales @tw15egan